fix: correct default branch detection and ensure consistent scanning … #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…behavior FIXED BUGS: - Default branch detection was not working properly in git repositories - make_default_branch and set_as_pending_head were inconsistently set - CLI would skip scans when manifest files hadn't changed (should always scan) - --default-branch flag was being overridden by SCM detection - GitLab CI integration wasn't detecting default branch correctly CORRECTED BEHAVIOR: - Always perform scans regardless of manifest file changes (API mode when no manifests changed) - Proper default branch detection priority system: 1. Explicit --default-branch flag (highest priority) 2. CI environment variables (GitHub Actions, GitLab CI) 3. Git repository analysis via git_repo.is_default_branch 4. Fallback to false - Both make_default_branch and set_as_pending_head now synchronized correctly - Force API mode enables non-blocking behavior when no manifest files changed ENHANCED AUTO-DETECTION: - Repository name from git remote origin (was manual) - Branch, commit SHA, message, and committer from git (was manual) - Changed files from git commit (was manual) - Better error handling for non-git repositories SIMPLIFIED CI/CD USAGE: - Most parameters now optional due to git auto-detection - Added production-ready workflow examples: - workflows/github-actions.yml - GitHub Actions with concurrency control - workflows/gitlab-ci.yml - GitLab CI with environment detection - workflows/bitbucket-pipelines.yml - Bitbucket with path filtering - Updated README with corrected parameter documentation The CLI now works as users expected: - GitHub: socketcli --target-path --scm github --pr-number - GitLab: socketcli --target-path --scm gitlab --pr-number - Local: socketcli --target-path ./project
dacoburn
requested review from
kapravel and
Planeshifter
and removed request for
a team
|
🚀 Preview package published! Install with: pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketsecurity==2.1.24.dev1Docker image: |
bcomnes
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…behavior
Root Cause
Forced API Mode for non manifest file changes in a Git Repo was not correctly setting/using the default branch.
Fix
FIXED BUGS:
CORRECTED BEHAVIOR:
ENHANCED AUTO-DETECTION:
SIMPLIFIED CI/CD USAGE:
The CLI now works as users expected:
Public Changelog